[llvm-commits] [PATCH][Review request] Mips direct object generation patch #4

[Bruno Cardoso Lopes]

Hi,

On Tue, Oct 25, 2011 at 10:13 PM, Carter, Jack <jcarter at mips.com> wrote:
> This is the fourth of six patches for Mips direct object generation.
>
>     lib/Target/Mips/MipsCodeEmitter.cpp
>     lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
>     lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.h

I believe you don't need the includes here:

+#include "llvm/Support/DataTypes.h"
+#include <string>
+

If you happen to need the first (which I don't believe you will),
include it in the .cpp file which needs it.
Also, merge this patch with another that change Mips*CodeEmitter files.

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc