[llvm-commits] [llvm] r142286 - /llvm/trunk/test/Transforms/SimplifyLibCalls/PR7357.ll

[Lang Hames]

No, unfortunately it doesn't. The existing int parser returns "0" when it
can't parse a string, and I'm currently allowing zero as a valid preferred
alignment (which is the last element of the string in constant-fold-gep) for
compatibility with existing behavior. The PR7357 case was caught when I
disallowed zero sized integers.

This seems a bit ugly, but Dan has convinced me that tidying up TargetData
is a bigger job that I'd realized, so I'm putting this work on the back
burner until I've had more time to think about it.

- Lang.

On Mon, Oct 17, 2011 at 4:16 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Oct 17, 2011, at 3:14 PM, Lang Hames wrote:
>
> > Not quite. Apparently the shell lines in the lit suite are tcl, which
> doesn't honor the embedded quote. This led to the trailing quote being
> passed through in the target data layout string. The parser used to swallow
> this silently, treating the resulting 'n32"' as zero and discard it. The new
> verifier barfed on it though (as it should).
>
> Does it also catch test/Other/constant-fold-gep.ll?
>
> /jakob
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111020/15242db7/attachment.html>