[llvm-commits] [llvm] r141569 - in /llvm/trunk: lib/CodeGen/MachineLICM.cpp test/CodeGen/ARM/lsr-unfolded-offset.ll test/CodeGen/X86/licm-dominance.ll test/CodeGen/X86/licm-nested.ll

[Devang Patel]

On Oct 10, 2011, at 1:20 PM, Evan Cheng wrote:

> On Oct 10, 2011, at 12:09 PM, Devang Patel wrote:
> 
>> 
>> /// Hoist - When an instruction is found to use only loop invariant operands
>> /// that are safe to hoist, this instruction is called to do the dirty work.
>> ///
>> @@ -1139,6 +1167,8 @@
>>    MI = ExtractHoistableLoad(MI);
>>    if (!MI) return false;
>>  }
>> +  if (!IsGuaranteedToExecute(MI))
>> +    return false;
> 
> Why is the check here? Shouldn't the check be in IsLICMCandidate()?

I put, potentially compile time expensive, dominator check in the end.
-
Devang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111010/8e8e3471/attachment.html>