[llvm-commits] [llvm] r140952 - /llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Duncan Sands baldrick at free.fr
Sun Oct 2 03:34:31 PDT 2011


Hi Nadav,

> --- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Sat Oct  1 13:39:28 2011
> @@ -1625,17 +1628,14 @@
>
>               for (unsigned Idx=0; Idx<NumElem; Idx++) {
>                 SDValue Ex = DAG.getNode(ISD::EXTRACT_VECTOR_ELT, dl,
> -                                       WideScalarVT, Tmp3, DAG.getIntPtrConstant(Idx));
> -
> -
> -              EVT NVT = EVT::getIntegerVT(*DAG.getContext(), ScalarSize);
> +                                WideScalarVT, Tmp3, DAG.getIntPtrConstant(Idx));
>
> -              Ex = DAG.getNode(ISD::TRUNCATE, dl, NVT, Ex);
> +              Ex = DAG.getNode(ISD::TRUNCATE, dl, EltVT, Ex);

it looks like you changed the behaviour here (NVT changed to EltVT).  So can you
please explain what you are fixing (your commit message didn't explain) and add
a testcase.

Thanks, Duncan.



More information about the llvm-commits mailing list