[llvm-commits] fixing the OCaml bindings for 3.0

Török Edwin edwintorok at gmail.com
Sat Oct 1 05:14:33 PDT 2011


Hi,

I noticed that currently the OCaml bindings don't pass the testsuite.
First problem is due to exception handling changes: invoke must point to a basic block with a landingpad,
otherwise verifier rejects it.

Attach patch tries to address that by exposing LLVMBuildLandingPad, and calling it: the verifier passes now.
There are still many grep failures left though, I'll probably go through these in the next days and try to figure what is wrong.

Some help would be appreciated, there are currently 158 grep failures (even after applying this patch), see log.gz.

How should we handle these patches? review -> commit, or commit -> review later?
(note some patches may need to introduce new bindings)

P.S. Who is the code owner for the OCaml bindings?

Best regards,
--Edwin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: log.gz
Type: application/gzip
Size: 4497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111001/328e8cc5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-attempt-to-fix-ocaml-bindings-landing-pads.patch
Type: text/x-diff
Size: 5007 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111001/328e8cc5/attachment.patch>


More information about the llvm-commits mailing list