[llvm-commits] [llvm] r140848 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

[Duncan Sands]

Hi Edwin,

> --- llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp (original)
> +++ llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp Fri Sep 30 07:31:57 2011
> @@ -114,6 +114,11 @@
>     : TargetMachine(T, Triple, CPU, FS) {
>     CodeGenInfo = T.createMCCodeGenInfo(Triple, RM, CM);
>     AsmInfo = T.createMCAsmInfo(Triple);
> +  // TargetSelect.h moved to different directory between LLVM 2.9 and 3.0,

to different -> to a different

> +  // and if the old one gets included then MCAsmInfo will be NULL and we'd crash

we'd -> we'll

> +  // later.
> +  // Provide the user a useful error message about whats wrong.

user a -> user with a
whats -> what's
Also, this line could be joined with the previous one.

> +  assert(AsmInfo&&  "MCAsmInfo not initialized. Make sure you include the correct TargetSelect.h!");

This line is too long.

Ciao, Duncan.