[llvm-commits] [patch] ThreeStageLoopUnroll

Devang Patel dpatel at apple.com
Tue Sep 27 14:55:19 PDT 2011


On Sep 27, 2011, at 2:48 PM, David Blaikie wrote:

> 2) General llvm convention is to avoid
> 
> +  bool candidate = L->isThreeStageUnrollCandidate(L, LI);
> +  if(candidate) {
> ….
> 
> and do
> 
> +  if (bool candidate = … ) {
> +  }
> 
> if candidate is not used outside "if".
> 
> At that point you might as well just write:
> 
> if (L->isThreeStageUnrollCandidate(L, LI)) {
> } 

Yes, if candidate is not used inside "if".
-
Devang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110927/4c216873/attachment.html>


More information about the llvm-commits mailing list