[llvm-commits] [llvm] r140356 - in /llvm/trunk: lib/MC/MCAsmInfoCOFF.cpp test/CodeGen/X86/hidden-vis.ll

[Eli Friedman]

Author: efriedma
Date: Thu Sep 22 19:13:02 2011
New Revision: 140356

URL: http://llvm.org/viewvc/llvm-project?rev=140356&view=rev
Log:
PR10989: Don't print .hidden on Windows.


Modified:
    llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp
    llvm/trunk/test/CodeGen/X86/hidden-vis.ll

Modified: llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp?rev=140356&r1=140355&r2=140356&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp (original)
+++ llvm/trunk/lib/MC/MCAsmInfoCOFF.cpp Thu Sep 22 19:13:02 2011
@@ -27,7 +27,8 @@
   LinkOnceDirective = "\t.linkonce discard\n";
   
   // Doesn't support visibility:
-  HiddenVisibilityAttr = ProtectedVisibilityAttr = MCSA_Invalid;
+  HiddenVisibilityAttr = HiddenDeclarationVisibilityAttr = MCSA_Invalid;
+  ProtectedVisibilityAttr = MCSA_Invalid;
 
   // Set up DWARF directives
   HasLEB128 = true;  // Target asm supports leb128 directives (little-endian)

Modified: llvm/trunk/test/CodeGen/X86/hidden-vis.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/hidden-vis.ll?rev=140356&r1=140355&r2=140356&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/hidden-vis.ll (original)
+++ llvm/trunk/test/CodeGen/X86/hidden-vis.ll Thu Sep 22 19:13:02 2011
@@ -1,8 +1,11 @@
 ; RUN: llc < %s -mtriple=i686-pc-linux-gnu | FileCheck %s -check-prefix=LINUX
 ; RUN: llc < %s -mtriple=i686-apple-darwin8 | FileCheck %s -check-prefix=DARWIN
+; RUN: llc < %s -mtriple=x86_64-w64-mingw32 | FileCheck %s -check-prefix=WINDOWS
+
 
 @a = hidden global i32 0
- at b = external global i32
+ at b = external hidden global i32
+ at c = global i32* @b
 
 define weak hidden void @t1() nounwind {
 ; LINUX: .hidden t1
@@ -10,15 +13,19 @@
 
 ; DARWIN: .private_extern _t1
 ; DARWIN: t1:
+
+; WINDOWS: t1:
+; WINDOWS-NOT: hidden
   ret void
 }
 
 define weak void @t2() nounwind {
-; LINUX: t2:
-; LINUX: .hidden a
-
-; DARWIN: t2:
-; DARWIN: .private_extern _a
+; DARWIN: .weak_definition	_t2
   ret void
 }
 
+; LINUX: .hidden a
+; LINUX: .hidden b
+
+; DARWIN: .private_extern _a
+; DARWIN-NOT: private_extern