[llvm-commits] [patch] fix PPCRegisterInfo.cpp comment typo

[Jim Grosbach]

Ignore me. I see now this was a proposed patch, not an actual commit.

What I get for reading mail late at night… Mea culpa.

-j
On Sep 22, 2011, at 12:26 AM, Jim Grosbach wrote:

> 
> 
> On Sep 21, 2011, at 10:51 PM, Liu <proljc at gmail.com> wrote:
> 
>> On Thu, Sep 22, 2011 at 9:09 AM, Bill Wendling <wendling at apple.com> wrote:
>>> On Sep 21, 2011, at 5:32 PM, Liu wrote:
>>> 
>>>> On Wed, Sep 21, 2011 at 12:59 AM, Liu <proljc at gmail.com> wrote:
>>>>> Hi all
>>>>> 
>>>>> I find a typo in PPCRegisterInfo.cpp comment and fixed it.
>>>>> 
>>>>> --Liu
>>>>> 
>>>> 
>>>> ping
>>>> 
>>>> --- a/lib/Target/PowerPC/PPCRegisterInfo.cpp
>>>> +++ b/lib/Target/PowerPC/PPCRegisterInfo.cpp
>>>> @@ -322,7 +322,7 @@ unsigned
>>>> findScratchRegister(MachineBasicBlock::iterator II, RegScavenger *RS,
>>>>                             const TargetRegisterClass *RC, int SPAdj) {
>>>>  assert(RS && "Register scavenging must be on");
>>>>  unsigned Reg = RS->FindUnusedReg(RC);
>>>> -  // FIXME: move ARM callee-saved reg scan to target independent code, then
>>>> +  // FIXME: move PPC callee-saved reg scan to target independent code, then
>>>>  // search for already spilled CS register here.
>>>>  if (Reg == 0)
>>>>    Reg = RS->scavengeRegister(RC, II, SPAdj);
>>>> --
>>>> 
>>>> Isn't it a typo?
>>> 
>>> I don't believe so. It's saying that the reg scan in ARM should be target independent. Once that's accomplished, we can use that functionality here.
>>> 
>>> -bw
>>> 
>>> 
>>> 
>> 
>> Thanks, I get.
>> 
> 
> Please revert. As bill points out, your change is not correct. 
> 
> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits