[llvm-commits] [llvm] r140178 - in /llvm/trunk/lib/Target/Mips: Mips.td MipsSubtarget.h

[Bruno Cardoso Lopes]

On Tue, Sep 20, 2011 at 2:28 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:
> I think we should first make it clear what these functions mean.
>
> This is what I intended:
> isMips32(): true for any architecture supporting Mips32r1
> (Mips32r1/r2, Mips64r1/r2)
> isMips32r2(): true for any architecture supporting Mips32r2 (Mips32r2, Mips64r2)
> isMips64(): true for any architecture supporting Mips64r1 (Mips64r1/r2)
> isMips64r2(): true for any architecture supporting Mips64r2 (Mips64r2)

I see now, I think this is ok, but should be renamed "hasMips32" and
so on to make it clear, because it makes sense to say that Mips64r2
has Mips32r2 but not that it "is" Mips32r2

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc