[llvm-commits] [patch] add MIPS64 SubTraget and stubs support to LLVM.

[Liu]

On Tue, Sep 20, 2011 at 2:09 AM, Bruno Cardoso Lopes
<bruno.cardoso at gmail.com> wrote:
> Hi,
>
> On Mon, Sep 19, 2011 at 2:35 AM, Liu <proljc at gmail.com> wrote:
>> Hi all
>>
>> I've add mips64 SubTarget and stubs support to llvm. Please review and checkin.
>
> Overall looks good, please fix the space alignment here:
>
> +  if ((TheTriple.getArch() == Triple::mips) ||
> +              (TheTriple.getArch() == Triple::mips64))
>
> Here:
>
> +    TargetRegistry::RegisterMCInstPrinter(TheMips64Target,
> +                                        createMipsMCInstPrinter);
> +  TargetRegistry::RegisterMCInstPrinter(TheMips64elTarget,
> +                                        createMipsMCInstPrinter);
>
> And here:
>
> +def FeatureMips64      : SubtargetFeature<"mips64", "MipsArchVersion",
> +                                "Mips64", "Mips64 ISA Support",
> +                                [FeatureGP64Bit, FeatureFP64Bit,
> +                               FeatureCondMov, FeatureBitCount]>;
>
> --
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc
>

Hi Bruno

Thanks for review, the space alignment is fixed:)


--Liu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-mips64-target-stubs.patch
Type: text/x-patch
Size: 14509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110920/4dd90a93/attachment.bin>