[llvm-commits] [llvm] r139820 - in /llvm/trunk: include/llvm/MC/MCInst.h include/llvm/MC/MCInstPrinter.h lib/MC/MCInst.cpp lib/MC/MCInstPrinter.cpp lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp lib/Target/X86/InstPrinter/X86ATTInstPrinter.cpp lib/Target/X86/InstPrinter/X86IntelInstPrinter.cpp

[Chris Lattner]

On Sep 15, 2011, at 12:30 PM, Jim Grosbach wrote:

>> +++ llvm/trunk/include/llvm/MC/MCInst.h Thu Sep 15 13:36:29 2011
>> @@ -129,6 +129,7 @@
>> class MCInst {
>>  unsigned Opcode;
>>  SmallVector<MCOperand, 8> Operands;
>> +  SmallVector<std::string, 1> Annotations;
> 
> We should really try very hard to find another way to do this. MCInst's are intended to be very small objects copied around by value on a regular basis, unlike MachineInstrs.

Yeah, this isn't acceptable.  Please revert and find another way to do this,

-Chris