[llvm-commits] [llvm] r139340 - /llvm/trunk/tools/gold/gold-plugin.cpp

[Rafael Ávila de Espíndola]

> Please, find the patch attached. It makes the diagnostics more precise
> and adds a fast path for skipping non-bitcode files, if Gold version
> supports get_view (i.e. gold is more-or-less recent). The latter is
> important for two reasons:
>
> - it's the common case for linking with the Gold plugin. It's good to
> avoid creating heavy-weight Bitcode reader.
> - after the change that has enabled these diagnostic messages, the
> users have started to see warnings like "bfd plugin: Failed to create
> LTO module: Invalid bitcode signature" which is definitely not
> desirable.

It would still print the warning with "old" versions of gold, no? Can 
you fix that too?

Alternatively, is that in some released version of gold already? If so 
you can probably just drop the if and assume we have a sufficiently 
recent gold.

> OK to commit?

OK with one of those changes.

> krasin

Thanks!
Rafael