[llvm-commits] [PATCH] [dragonegg] Enable flag_functions_from_args for GNU Go

Ivan Krasin krasin at google.com
Tue Sep 13 21:44:01 PDT 2011


On Tue, Sep 13, 2011 at 9:46 PM, Sanjoy Das
<sanjoy at playingwithpointers.com> wrote:
> Hi!
>
>> Will this change be needed if the bug in gccgo is fixed? If not, I
> No.
>
>> would suggest to add a note why this line is there.
>
> flag_functions_from_args is already documented earlier in the same
> file.  Is re-stating necessary?
>
> /// flag_functions_from_args - Construct function prototypes from the
> argument
> /// list, ignoring the function type.  This is helpful if the language
> front-end
> /// sometimes creates functions and/or calls where the arguments do not
> match
> /// the arguments given in the function type.
> bool flag_functions_from_args;
Thanks. I agree, it's absolutely clear definition. No need in additional notes.

>
> Thanks!
> --
> Sanjoy Das
> http://playingwithpointers.com
>




More information about the llvm-commits mailing list