[llvm-commits] [PATCH] Rename LLVM_MULTITHREADED define and fix build without threads

arrowdodger 6yearold at gmail.com
Tue Sep 13 01:35:50 PDT 2011


On Mon, Sep 12, 2011 at 10:09 PM, Eric Christopher <echristo at apple.com>wrote:

> Sorry for the delay. In general the patch is fine, could you change these
> couple of things?
>
> LLVM_HAVE_ATOMICS -> LLVM_HAS_ATOMICS
>

A lot of other defines have _HAVE_, not _HAS_, so i thought it would be
consistent. Fixed, anyway.

and
>
> -#if LLVM_MULTITHREADED==0
> +#if LLVM_HAVE_ATOMICS==0 || !defined(LLVM_HAVE_ATOMICS)
>
> to just #if LLVM_HAS_ATOMICS
>
> this latter is ok because we define it either way so there's always a value
> at least as far as the autoconf bits are concerned. If this isn't true for
> the cmake bits let me know.
>

I've changed config headers templates for cmake build to make them always
contain such definition.

Also, i've updated configure script itself too. Patch attached.
Thanks for your attention to this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110913/a9364512/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.atomics.define.diff
Type: text/x-patch
Size: 6844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110913/a9364512/attachment.bin>


More information about the llvm-commits mailing list