[llvm-commits] [PATCH]Gold plugin: don't report error on ELF file

Ivan Krasin krasin at chromium.org
Mon Sep 12 14:37:55 PDT 2011


On Mon, Sep 12, 2011 at 2:36 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On Sep 12, 2011, at 2:29 PM, Ivan Krasin wrote:
>
>> FYI: I'm under impression that this patch fits to this point of the
>> LLVM Developer policy:
>>
>> """You are allowed to commit patches without approval which you think
>> are obvious. This is clearly a subjective decision — we simply expect
>> you to use good judgement. Examples include: fixing build breakage,
>> reverting obviously broken patches, documentation/comment changes, any
>> other minor changes."""
>>
>> This patch is close to obvious and it fixes the build 'breakage' for
>> some systems (which are experienced a huge slowdown due to
>> hundreds/thousands of false warnings).
>>
>> So, I would probably submit this patch tonight, if nobody complains about that.
>
> Most of the people that care about the gold plugin work with you… I'm sure they can find you if you break it more. Feel free to commit it.
Thanks, Eric!

>
> -eric




More information about the llvm-commits mailing list