[llvm-commits] [llvm] r139407 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp test/CodeGen/ARM/2011-09-09-OddVectorDivision.ll

Tobias Grosser tobias at grosser.es
Mon Sep 12 12:03:03 PDT 2011


On 09/12/2011 07:50 PM, Eli Friedman wrote:
> On Mon, Sep 12, 2011 at 11:42 AM, Tobias Grosser<tobias at grosser.es>  wrote:
>> On 09/12/2011 05:36 PM, Jakob Stoklund Olesen wrote:
>>>
>>> On Sep 9, 2011, at 2:04 PM, Eli Friedman wrote:
>>>
>>>> --- llvm/trunk/test/CodeGen/ARM/2011-09-09-OddVectorDivision.ll (added)
>>>> +++ llvm/trunk/test/CodeGen/ARM/2011-09-09-OddVectorDivision.ll Fri Sep
>>>>   9 16:04:06 2011
>>>> @@ -0,0 +1,23 @@
>>>> +; RUN: llc -mtriple=armv7-- %s -mattr=-neon
>>>
>>> Eli,
>>>
>>> This test is leaving temporary files in the test directory.
>>>
>>> Please use '<    %s' instead of '%s'.
>>
>> Hey Jacob,
>>
>> can you explain why '<  %s' is preferred to '%s'. I personally like '%s'
>> better, as it is easier to append to the gdb command line 'gdb --args ...'.
>> What is the downside of using '%s'? What do I loose?
>
> If you don't specify the output as stdout, either explicitly or
> implicitly, you end up leaving temporary files in strange locations.

OK, got it. Thanks a lot.

Tobi




More information about the llvm-commits mailing list