[llvm-commits] [llvm] r139340 - /llvm/trunk/tools/gold/gold-plugin.cpp

[Duncan Sands]

Hi Ivan,

> Please, find the patch attached. It makes the diagnostics more precise
> and adds a fast path for skipping non-bitcode files, if Gold version
> supports get_view (i.e. gold is more-or-less recent). The latter is
> important for two reasons:
>
> - it's the common case for linking with the Gold plugin. It's good to
> avoid creating heavy-weight Bitcode reader.
> - after the change that has enabled these diagnostic messages, the
> users have started to see warnings like "bfd plugin: Failed to create
> LTO module: Invalid bitcode signature" which is definitely not
> desirable.
>
> OK to commit?

I'm not competent to review this patch, sorry.

Ciao, Duncan.