[llvm-commits] [llvm] r139067 - /llvm/trunk/lib/Target/X86/X86InstrSSE.td

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Tue Sep 6 10:59:14 PDT 2011


This are all duplications of SSE patterns already in the .td file.
None of the commits has added a new pattern for SSE instructions nor
modified the behavior. I don't have testcases, this duplication is
something I've done in mass since last year and I'm just fulfilling
the holes, as to trying to compile and execute the llvm testsuite with
AVX turned on (and make sure we don't have code size and performance
regressions). If you feel this is not the way to go, I can revert all
last 30 commits I've done, but I won't add testcases for all those
right now. My future plan though is organize all sse tests in
test/CodeGen/X86 (which are quite messy) and then duplicate all
relevant ones to check for AVX versions instead.

On Tue, Sep 6, 2011 at 9:11 AM, Eric Christopher <echristo at apple.com> wrote:
>
> On Sep 2, 2011, at 5:46 PM, Bruno Cardoso Lopes wrote:
>
>> Author: bruno
>> Date: Fri Sep  2 19:46:54 2011
>> New Revision: 139067
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=139067&view=rev
>> Log:
>> Add AVX pattern versions for PSHUFB,PSIGN{B,W,D}
>
> Testcases for all of these? :)
>
> -eric
>



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc




More information about the llvm-commits mailing list