[llvm-commits] [llvm] r138831 - /llvm/trunk/test/CodeGen/X86/segmented-stacks.ll

Eric Christopher echristo at apple.com
Tue Sep 6 09:27:16 PDT 2011


On Sep 3, 2011, at 8:27 PM, Rafael Ávila de Espíndola wrote:

>> The first darwin failure after r138821 was:
>> Assertion failed: (!Subtarget->isTargetEnvMacho()), function LowerDYNAMIC_STACKALLOC, file .../llvm/lib/Target/X86/X86ISelLowering.cpp, line 8853.
> 
> Sorry for taking so long to reply.
> 
> The attached patch turns the assert into a fatal error. Is it OK?

Sure. Can you also add a check in X86Subtarget similar to the 64-bit problem to verify that no one has asked for it as well on targets that aren't supported?

-eric



More information about the llvm-commits mailing list