[llvm-commits] Patch to add support for WidenVecRes_MERGE_VALUES

[Villmow, Micah]

Thanks, closed bug10736.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Eli Friedman
> Sent: Wednesday, August 31, 2011 11:38 AM
> To: Villmow, Micah
> Cc: llvm-commits; Tobias Grosser
> Subject: Re: [llvm-commits] Patch to add support for
> WidenVecRes_MERGE_VALUES
> 
> r138877.
> 
> -Eli
> 
> On Tue, Aug 30, 2011 at 6:45 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > Here is a combined patch.
> >
> >> -----Original Message-----
> >> From: Eli Friedman [mailto:eli.friedman at gmail.com]
> >> Sent: Tuesday, August 30, 2011 1:09 PM
> >> To: Villmow, Micah
> >> Cc: Tobias Grosser; llvm-commits
> >> Subject: Re: [llvm-commits] Patch to add support for
> >> WidenVecRes_MERGE_VALUES
> >>
> >> On Tue, Aug 30, 2011 at 1:06 PM, Villmow, Micah
> <Micah.Villmow at amd.com>
> >> wrote:
> >> > Eli,
> >> >  So for the other cases, it would just be call
> DecomposeMERGE_VALUES
> >> and then call the correct
> >> > legalization function on the return value, correct?
> >>
> >> Yes.
> >>
> >> > I'll send a second patch with those later.
> >>
> >> Great, thanks.
> >>
> >> -Eli
> >>
> >> > Micah
> >> >
> >> >> -----Original Message-----
> >> >> From: Eli Friedman [mailto:eli.friedman at gmail.com]
> >> >> Sent: Tuesday, August 30, 2011 12:56 PM
> >> >> To: Tobias Grosser
> >> >> Cc: Villmow, Micah; llvm-commits
> >> >> Subject: Re: [llvm-commits] Patch to add support for
> >> >> WidenVecRes_MERGE_VALUES
> >> >>
> >> >> On Tue, Aug 30, 2011 at 11:35 AM, Tobias Grosser
> <tobias at grosser.es>
> >> >> wrote:
> >> >> > On 08/30/2011 01:04 PM, Villmow, Micah wrote:
> >> >> >>
> >> >> >> Thanks for the feedback, new revision attached.
> >> >> >
> >> >> > There seems one unneeded white space change. (Can be fixed on
> >> commit)
> >> >> >
> >> >> >> SDValue MakeLibCall(RTLIB::Libcall LC, EVT RetVT,
> >> >> >>                    const SDValue *Ops, unsigned NumOps, bool
> >> >> isSigned,
> >> >> >>                    DebugLoc dl);
> >> >> >> +
> >> >> >>        std::pair<SDValue, SDValue>
> >> >> ExpandChainLibCall(RTLIB::Libcall
> >> >> >
> >> >> > Otherwise, it looks good. Let's see if Eli has any additional
> >> >> comments.
> >> >>
> >> >> Looks fine.
> >> >>
> >> >> Note that it would be nice to make sure we implement MERGE_VALUES
> >> for
> >> >> all the other cases in type legalization... (integer promotion,
> >> vector
> >> >> scalarization, etc.)
> >> >>
> >> >> -Eli
> >> >
> >> >
> >> >
> >
> >
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits