[llvm-commits] [llvm] r138864 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/2011-08-29-BlockConstant.ll

[Chris Lattner]

On Aug 31, 2011, at 10:30 AM, David Greene wrote:
> Author: greened
> Date: Wed Aug 31 12:30:56 2011
> New Revision: 138864
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=138864&view=rev
> Log:
> Compress Repeated Byte Output
> 
> Emit a repeated sequence of bytes using .zero.  This saves an enormous
> amount of asm file space for certain programs.

Looks good David, one minor thing that I missed before:

> +    if (Value != -1) {
> +      unsigned Bytes = AP.TM.getTargetData()->getTypeAllocSize(CA->getType());
> +      AP.OutStreamer.EmitFill(Bytes, Value, AddrSpace);
> +    }

"Bytes" should be a uint64_t.  Sizes should be 64-bit, even if "index counts" are not.

-Chris