[llvm-commits] [llvm] r138660 - in /llvm/trunk: lib/Target/X86/X86.td lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrCompiler.td lib/Target/X86/X86InstrInfo.td lib/Target/X86/X86Subtarget.cpp lib/Target

[Eli Friedman]

On Fri, Aug 26, 2011 at 4:59 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On Aug 26, 2011, at 2:21 PM, Eli Friedman wrote:
>
> +def FeatureCMPXCHG16B : SubtargetFeature<"cmpxchg16b", "HasCmpxchg16b",
> "true",
> +                                      "64-bit with cmpxchg16b",
> +                                      [Feature64Bit]>;
>
> This seems rather convoluted - or at least I'm not sure why you'd want to
> hide Feature64Bit inside of the cmpxchg check.

Mostly to make the CPU descriptions a bit shorter... I can change it
so they're both listed explicitly if you want.

> Otherwise it looks good. :)

Thanks. :)

-Eli