[llvm-commits] [llvm] r138373 - /llvm/trunk/lib/Target/ARM/ARMFastISel.cpp

Eric Christopher echristo at apple.com
Tue Aug 23 14:12:01 PDT 2011


On Aug 23, 2011, at 2:04 PM, Jim Grosbach wrote:

> 
> On Aug 23, 2011, at 1:59 PM, Eric Christopher wrote:
> 
>> 
>> On Aug 23, 2011, at 1:53 PM, Jim Grosbach wrote:
>> 
>>> Author: grosbach
>>> Date: Tue Aug 23 15:53:08 2011
>>> New Revision: 138373
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=138373&view=rev
>>> Log:
>>> [SU]XT[BH] are only available on ARMv6 and up.
>>> 
>> 
>> Hmm.. the pass probably makes this assumption in more places. Might be worth just making the whole thing conditional on that. Right now it's conditional on darwin which I think implies that anyhow (by default).
> 
> That's just a little bit bigger hammer than I was wanting to swing for this. I'm totally OK with it if you think that's the best solution, though.

Hmm.. well, the code is pretty untested on processors that don't support armv6, then again most of the arm port is untested on processors that don't support armv6.

Six of oneā€¦

-eric



More information about the llvm-commits mailing list