[llvm-commits] [llvm] r137694 - /llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

Eli Friedman eli.friedman at gmail.com
Mon Aug 15 17:41:37 PDT 2011


Author: efriedma
Date: Mon Aug 15 19:41:37 2011
New Revision: 137694

URL: http://llvm.org/viewvc/llvm-project?rev=137694&view=rev
Log:
After talking with Bill, it seems like the LandingPad handling here is likely
to be wrong (or at least somewhat suspect).  Leave a FIXME for Bill.



Modified:
    llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

Modified: llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp?rev=137694&r1=137693&r2=137694&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp Mon Aug 15 19:41:37 2011
@@ -2266,10 +2266,7 @@
                  !isa<LandingPadInst>(BBI)) {
         break;
       }
-      // Note that deleting LandingPad's here is in fact okay, although it
-      // involves a bit of subtle reasoning. If this inst is a LandingPad,
-      // all the predecessors of this block will be the unwind edges of Invokes,
-      // and we can therefore guarantee this block will be erased.
+      // FIXME: Handling of LandingPadInst (landingpad) is suspicious.
     }
 
     // Delete this instruction (any uses are guaranteed to be dead)





More information about the llvm-commits mailing list