[llvm-commits] [llvm] r137691 - in /llvm/trunk: lib/Transforms/Utils/SimplifyCFG.cpp test/Transforms/SimplifyCFG/trapping-load-unreachable.ll

[Bill Wendling]

On Aug 15, 2011, at 5:25 PM, Eli Friedman wrote:

>> My point is that removing landingpad instructions is very tricky, and should be done only if all of the invokes unwinding to the landing pad have been removed or converted into 'call's. :-)
> 
> What the code currently does is if there is a landingpad followed by
> an unreachable, it will remove the block and change all invokes
> referring to it into calls.  From what you're saying, it sounds like
> that is correct, but we won't want to do it once we have terminate?
> 
I would rather that it be kept around and that the only time we delete the landingpad instruction and block is when all invokes that unwind to it are removed or changed into calls. The current way, it's removing the landing pad block and then changing the invokes to calls.

-bw