[llvm-commits] [PATCH] Correctly fail decoding of LDRD with odd Rt field

James Molloy James.Molloy at arm.com
Mon Aug 15 14:04:17 PDT 2011


Owen,

Much appreciated, thanks! I didn't get time to change the patch tonight.

James
________________________________________
From: Owen Anderson [resistor at me.com]
Sent: 15 August 2011 21:53
To: James Molloy
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Correctly fail decoding of LDRD with odd Rt field

I went ahead and corrected the tests, and applied your patch as r137647.

--Owen

On Aug 15, 2011, at 12:13 PM, James Molloy wrote:

> Hi Owen,
>
> I do apologise, it appears my tree was a few days old and those tests didnt exist.
>
> The tests are totally incorrect. I'll attach an updated patch file that adapts the test shortly.
>
> Cheers,
>
> James
>
>
> On 15 Aug 2011, at 19:52, "Owen Anderson" <resistor at me.com<mailto:resistor at me.com>> wrote:
>
> James,
>
> This looks good in principle, but I'm seeing a number of failures on MC/Disassembler/ARM/memory-arm-instructions.txt.  Perhaps the old tests need to be updated?
>
> --Owen
>
> On Aug 15, 2011, at 7:50 AM, James Molloy wrote:
>
> Hi,
>
> The attached patch causes decoding to fail if the Rt field of an LDRD/STRD is odd (Rt&0x1 != 0), as specified in A.6.68. Testcase added.
>
> I wanted to add an assert to the encoder too, but couldn't see an obvious way to do this as the Rt field is decoded by the generic "getMachineOpValue()" function direct from tablegen.
>
> Cheers,
>
> James
>
> <LDRDSTRD.patch>_______________________________________________
> llvm-commits mailing list
> <mailto:llvm-commits at cs.uiuc.edu>llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.





More information about the llvm-commits mailing list