[llvm-commits] [PATCH] Correctly fail decoding of LDRD with odd Rt field

Owen Anderson resistor at me.com
Mon Aug 15 11:51:31 PDT 2011


James, 

This looks good in principle, but I'm seeing a number of failures on MC/Disassembler/ARM/memory-arm-instructions.txt.  Perhaps the old tests need to be updated?

--Owen

On Aug 15, 2011, at 7:50 AM, James Molloy wrote:

> Hi,
>  
> The attached patch causes decoding to fail if the Rt field of an LDRD/STRD is odd (Rt&0x1 != 0), as specified in A.6.68. Testcase added.
>  
> I wanted to add an assert to the encoder too, but couldn't see an obvious way to do this as the Rt field is decoded by the generic "getMachineOpValue()" function direct from tablegen.
>  
> Cheers,
>  
> James
>  
> <LDRDSTRD.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110815/fe4b8491/attachment.html>


More information about the llvm-commits mailing list