[llvm-commits] [PATCH] Fixes in ARM TableGen

Jim Grosbach grosbach at apple.com
Mon Aug 15 11:40:48 PDT 2011


On Aug 15, 2011, at 11:37 AM, Eric Christopher wrote:

> 
> On Aug 15, 2011, at 7:22 AM, James Molloy wrote:
> 
>> Hi,
>>  
>> The attached patch does three things (they're each so small I kept them in the same patch file - hope this is OK):
>>  
>> ·         Fix the field offsets for UMAAL - RdHi and RdLo were the incorrect way around (see A8.6.244). This required a fix to a test.
>> ·         Set the DecoderMethod for STRH (and other addrmode3 stores) correctly.
>> ·         Remove two pieces of dead code - class AI3stridx and class AIsthpr in ARMInstrFormats.td were not used anywhere.
>>  
>> Cheers,
>>  
>> James
>> <STRH_UMAAL.patch>_______________________________________________
> 
> LGTM.
> 
> Any objections Jim?


OK w/ me. I would prefer the changes be checked in as separate patches, though, even though they're very small. Keeps the revision history easier to follow.

-jim



More information about the llvm-commits mailing list