[llvm-commits] [llvm] r137551 - in /llvm/trunk: lib/Target/ARM/ARMExpandPseudoInsts.cpp test/CodeGen/ARM/2011-08-12-vmovqqqq-pseudo.ll

[Jakob Stoklund Olesen]

On Aug 12, 2011, at 10:14 PM, Bob Wilson wrote:

> Author: bwilson
> Date: Sat Aug 13 00:14:55 2011
> New Revision: 137551
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=137551&view=rev
> Log:
> Expand VMOVQQQQ pseudo instructions.
> 
> Apparently we never added code to expand these pseudo instructions, and in
> over a year, no one has noticed.  Our register allocator must be awesome!

Yep!

As far as I can tell, VMOVQQQQ is only ever created by ARMBaseInstrInfo::copyPhysReg now.

I don't think it would be a problem to expand the instruction directly in copyPhysReg. That way you can eliminate the pseudo completely.

QQQQ copies are represented with abstract COPY instructions during register allocation, so the pseudo probably doesn't help us any more.

/jakob