[llvm-commits] [PATCH] Add Pattern ID Information

[Rotem, Nadav]

David, 

Your infrastructure patches are wonderful, but how are they related to AVX ? Why don't you release some of your AVX patches so that we can start reviewing them. Even if they only compile against older LLVM versions. 

Nadav

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Chris Lattner
Sent: Thursday, August 04, 2011 04:02
To: David Greene
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Add Pattern ID Information

On Aug 3, 2011, at 4:38 PM, David Greene wrote:
> I've got a patch series ready to implement support for printing asm comments
> about instruction selection.  For example:
> 
>        incq    %rdx                    # test.c:38
>                                        #  Src: (add:i64 GR64:i64:$src, 1:i64)
>                                        #  Dst: (INC64r:i64 GR64:i64:$src)

Out of curiosity, how is this any better than just listing the 'INC64r' opcode?  We already have that accessible and don't need to add anything to MachineInstr to get it.

> This is really helpful for tracking down isel issues and was invaluable during
> AVX implementation and tuning.  So I want to get this in before I start doing
> the heavy-duty AVX merging.

What merging do you anticipate?  Mainline supports almost all of AVX, there are just a few bugs left and missed optimizations.

-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.