[llvm-commits] [llvm] r136485 - /llvm/trunk/utils/TableGen/

[Chris Lattner]

On Jul 29, 2011, at 12:07 PM, David Greene wrote:

> Author: greened
> Date: Fri Jul 29 14:07:05 2011
> New Revision: 136485
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=136485&view=rev
> Log:
> [AVX] Constify Inits
> 
> Make references to Inits const everywhere.  This is the final step
> before making them unique.

Please don't do this.  Instead, just remove all the mutating members.

'const' is only useful to use when some instances of a type are mutable and some are immutable.  With this sort of type, the keyword is useful to distinguish between the two cases.

If a type is *only* immutable, 'const' is just noise in the codebase.  This is why llvm::Type is no longer const qualified anywhere.

-Chris