[llvm-commits] [Patch] Removal of Unwind from C-API

[Bill Wendling]

On Jul 28, 2011, at 1:31 PM, Duncan Sands wrote:

> Hi Bill,
> 
>> --- include/llvm-c/Core.h	(revision 136325)
>> +++ include/llvm-c/Core.h	(working copy)
>> @@ -125,7 +125,7 @@
>>    LLVMSwitch         = 3,
>>    LLVMIndirectBr     = 4,
>>    LLVMInvoke         = 5,
>> -  LLVMUnwind         = 6,
>> +  /* Skipping 6 */
>>    LLVMUnreachable    = 7,
> 
> rather than removing these, it might be better to comment them out with a
> note that Unwind has been removed from LLVM.  That might help people
> using the C API to understand what happened.  I'm not sure this is really
> a good idea - just a thought.
> 
I'm of two minds about that. But it appears that people mostly get upset that we don't document our API changes well enough. So I think the solution would be to properly document this on a webpage somewhere. I would really rather not have dead code laying around...

-bw