[llvm-commits] [PATCH] New (C++0x) atomics: start implementation of 'fence' instruction

[Bill Wendling]

On Jul 25, 2011, at 4:09 PM, Eli Friedman wrote:

> On Sat, Jul 23, 2011 at 6:59 PM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>>> Index: include/llvm/Instruction.def
>>> ===================================================================
>>> --- include/llvm/Instruction.def      (revision 135822)
>>> +++ include/llvm/Instruction.def      (working copy)
>>> @@ -133,41 +133,42 @@
>>>  HANDLE_MEMORY_INST(27, Load  , LoadInst  )  // Memory manipulation instrs
>>>  HANDLE_MEMORY_INST(28, Store , StoreInst )
>>>  HANDLE_MEMORY_INST(29, GetElementPtr, GetElementPtrInst)
>>> -  LAST_MEMORY_INST(29)
>>> +HANDLE_MEMORY_INST(30, Fence , FenceInst )
>> 
>> I assume you're skipping 31 and 32 here to save space for atomicrmw and cmpxchg?
>> 
>>> +  LAST_MEMORY_INST(32)
> 
> Yes.
> 
> And I just spotted an error a few lines down here; minor editing glitch.
> 
Okay. Then you'll want to modify llvm-c/Core.h. It seems like it needs to be in sync with these numbers. :)

-bw