[llvm-commits] [PATCH] x86: Allow using unpack for shuffles in more situations

Jeff Muizelaar jmuizelaar at mozilla.com
Thu Jul 21 20:07:12 PDT 2011


On 2011-07-21, at 9:10 PM, Bruno Cardoso Lopes wrote:

> Hi Jeff,
> 
> On Thu, Jul 21, 2011 at 12:41 PM, Jeff Muizelaar <jmuizelaar at mozilla.com> wrote:
>> When investigating PR10171 I noticed that we already have code to turn shuffles into unpacks we just don't use it when VT == MVT::v2i64 or MVT::v2f64. I couldn't see any reason not to use it in those situations so this patch removes the check.
> 
> The checks are there because we're in the middle of a shuffle handling
> rewritten, and we are keeping some track of the types. However, your
> patch looks good to me, can you provide testcases (as in
> test/CodeGen/X86/...) with the patch? With a testcase showing the
> improvements I would be happy to apply.


Something like the attached?

-Jeff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shuf-unpack
Type: application/octet-stream
Size: 3122 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110721/2cb0eb03/attachment.obj>


More information about the llvm-commits mailing list