[llvm-commits] [llvm] r135645 - /llvm/trunk/lib/Target/X86/X86FrameLowering.cpp

[Bill Wendling]

On Jul 21, 2011, at 2:28 AM, Anton Korobeynikov wrote:

> Hi Bill,
> 
>> -                TII.get(Is64Bit ? X86::AND64ri32 : X86::AND32ri),
>> -                StackPtr).addReg(StackPtr).addImm(-MaxAlign);
>> +                TII.get(Is64Bit ? X86::AND64ri32 : X86::AND32ri), StackPtr)
>> +        .addReg(StackPtr)
>> +        .addImm(-MaxAlign)
>> +        .setMIFlag(MachineInstr::FrameSetup);
> What do you think - maybe we'll introduce the BuildFrameSetupMI helper
> method? Just to make sure we won't miss .setMIFlag calls in such
> cases?
> 
It might not be a bad idea. :-)

-bw