[llvm-commits] [PATCH] Document how to maintain a git-svn clone of the LLVM git repositories

NAKAMURA Takumi geek4civic at gmail.com
Wed Jul 20 10:08:16 PDT 2011


Jakob,

2011/7/21 Jakob Stoklund Olesen <stoklund at 2pi.dk>:
>> BTW, setting up authorsfile might be pain, but it should reduce
>> accidental undesirable committing by git-svn fetch. (Please consider,
>> what would happen if "-l" were missed on executing "git-svn rebase"?)
>
> For those who don't know, the problem is that 'git svn dcommit' will create a different local commit hash than the git mirror if the two log messages are not exactly identical. Since the log message includes the committer's name and email, those must be identical as well. After committing, you need to pull from the git mirror to get the canonical hash.
>
> I don't like any solution that depends on using an author file. It is simply too fragile to try to produce the same SHA-1 on the server and locally by having identical author files.
>
> Please make sure your instructions deal with that issue in a robust way.

I don't assume the person should have the "authorsfile" identical to
llvm.org/git.
Simply, each authorsfile may have one line, his own entry. For example for me,

chapuni = NAKAMURA Takumi <geek4civic at gmail.com>

git-svn fetch (and fetching triggered by git-svn dcommit) will reject
(and stop) 3rd person's commits.
Then, the person can know he would need "git-pull".

I guess it could be also newbie-proof, ... as far as the line in
authorsfile would be correct.
As an option, it may be described in the document, I think. Still pain to us?

Thank you.
...Takumi




More information about the llvm-commits mailing list