[llvm-commits] [PATCH] Make Inits FoldingSetNodes

David A. Greene greened at obbligato.org
Fri Jul 15 16:56:06 PDT 2011


Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> I have a patch that interns all the RecTy objects. It reduces TableGen
> heap usage from 24 MB to 16 MB IIRC. That is a lot in relative terms,
> but not in absolute terms, and it didn't improve parse time by much. I
> didn't think it was worth the churn at the time, but since you are
> churning in the same code now, I can send you the patch if you are
> interested.

Actually, this could help the Init effort quite a bit.  Interning RecTys
and making them unique means I can avoid string hash/compare for all
Inits that have a type.

So yeah, if you could commit that patch series _before_ mine, that would
be great.  I think it best that it go in before any of my series.

Are you willing and able to commit your patch set?

                                -Dave



More information about the llvm-commits mailing list