[llvm-commits] [PATCH] Remove Mutating Init Members

David A. Greene dag at cray.com
Thu Jul 14 13:58:05 PDT 2011


Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> On Jul 13, 2011, at 3:31 PM, David Greene wrote:
>
>> Here's a patch to remove members from Inits that update their state.
>> This is in preparation for making Inits const and ultimately making
>> them FoldingSetNodes.
>> 
>> Please review.  Thanks!
>
> Thanks for splitting it up, David.
>
> Besides the ArrayRef thing that Nick proposed, this all looks good to me.

Cool.  I made the ArrayRef change and things do look at lot better.
Thanks to you and Nick for pointing that out!

As soon as Chris and I resolve the FoldingSetNode thing I'll be sending
it all up.

                              -Dave



More information about the llvm-commits mailing list