[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

David A. Greene greened at obbligato.org
Tue Jul 12 11:00:42 PDT 2011


Chris Lattner <clattner at apple.com> writes:

>> I requested a review five days ago.  I cannot wait a week for every
>> change I need to make for AVX.  It will never get done.  I am very happy
>> to have things reviewed but reviewers need to be prompt.
>
> If you're not getting a response, please ping the patch like everyone
> else.  Ignoring policy is not the solution.

I don't want to ignore policy.  But _every_ _single_ _time_ I've sent a
patch for review, it's taken days and multiple pings to even have it
acknowledged and more time after that for the actual reviews to trickle
in.

I have seen the same happen to other submitters repeatedly.

I'm all for code review, especially on complex patches.  That's why I
sent this one for review ahead of time.  But the submitter needs to get
at least some indication someone is looking at it in a timely manner.
Otherwise the submitter is completely in the dark.

                         -Dave



More information about the llvm-commits mailing list