[llvm-commits] Add to RuntimeDyld support different object formats

Jim Grosbach grosbach at apple.com
Tue Jul 12 09:51:37 PDT 2011


On Jul 7, 2011, at 11:33 AM, Danil Malyshev wrote:

> Hi,
> 
> Please find attached the patch with the changes Jim has asked.
> 
>> A brief brain-dump of some things I've been thinking about but may not 
>> be readily apparent from the code as it currently exists:
> 
> All of that makes sense. We also need to find a way to properly abstract and separate the target-specific relocations implementation from the file format and common code. I.e. ELF -> REL/RELA -> ARM Machine Type relocations.
> 

Great! One more very minor thing; function names should start with lower case (IsKnownFormat should be isKnownFormat, for example). There are a couple of those.

OK for commit with that change. Do you have commit access?

> Regards,
> Danil
> <RuntimeDyld_different_object_formats-02.patch>




More information about the llvm-commits mailing list