[llvm-commits] [PATCH] Make TableGen Inits FoldingSetNodes

David A. Greene greened at obbligato.org
Mon Jul 11 12:02:02 PDT 2011


Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> On Jul 8, 2011, at 9:41 AM, David Greene wrote:
>
>     Here's a patch to manage TableGen Inits using a FoldingSet.  This allows
>     us to clean up all of the allocated Inits on TableGen exit, saves memory
>     and makes TableGen run a bit faster due to elimination of duplicate
>     objects.
>
> Very nice. Please use get() instead of Create().

Is there a naming convention here?  I've seen Create() used in other
places, which is why I used it.  :)

                            -Dave



More information about the llvm-commits mailing list