[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[Jakob Stoklund Olesen]

On Jul 11, 2011, at 11:25 AM, David Greene wrote:

> Author: greened
> Date: Mon Jul 11 13:25:51 2011
> New Revision: 134907
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=134907&view=rev
> Log:
> [AVX] Make Inits Foldable
> 
> Manage Inits in a FoldingSet.  This provides several benefits:
> 
> - Memory for Inits is properly managed
> 
> - Duplicate Inits are folded into Flyweights, saving memory
> 
> - It enforces const-correctness, protecting against certain classes
>  of bugs
> 
> The above benefits allow Inits to be used in more contexts, which in
> turn provides more dynamism to TableGen.  This enhanced capability
> will be used by the AVX code generator to a fold common patterns
> together.

David, please revert this.

You are ignoring code review, violating the coding standards, and there are mismatched tags.

/jakob