[llvm-commits] [llvm] r134577 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h include/llvm/Target/TargetFrameLowering.h lib/MC/MCDwarf.cpp lib/Target/TargetAsmInfo.cpp lib/Target/X86/X86FrameLowering.cpp lib/Target/X86/X86FrameLowering.h

[Chris Lattner]

On Jul 6, 2011, at 9:40 PM, Bill Wendling wrote:
>>> @@ -189,6 +190,14 @@
>>> ///
>>> virtual void processFunctionBeforeFrameFinalized(MachineFunction &MF) const {
>>> }
>>> +
>>> +  /// getCompactUnwindEncoding - Get the compact unwind encoding for the
>>> +  /// function. Return 0 if the compact unwind isn't available.
>>> +  virtual uint32_t getCompactUnwindEncoding(const std::vector<MCCFIInstruction>&,
>>> +                                            int /*DataAlignmentFactor*/,
>>> +                                            bool /*IsEH*/) const {
>> 
>> Please put names on these arguments like other stuff in this file.  Instead of taking a const vector, should this take an ArrayRef?
>> 
> Okay. Then I had to have the #include "llvm/MC/MCDwarf.h" in there or I get these errors:
> /Users/void/llvm/llvm.src/include/llvm/Target/TargetAsmInfo.h:89:42: note: in instantiation of member function
>      'llvm::ArrayRef<llvm::MCCFIInstruction>::ArrayRef' requested here
>    return TFI->getCompactUnwindEncoding(Instrs, DataAlignmentFactor, IsEH);
>                                         ^

Please move the method body out of line.  Also, please forward declare ArrayRef too.

-Chris