[llvm-commits] Add to RuntimeDyld support different object formats

[Eli Friedman]

On Fri, Jul 1, 2011 at 12:55 AM, Danil Malyshev
<dmalyshev at accesssoftek.com> wrote:
> Hello everyone,
>
>
>
> Please find attached the patch for review.
>
> This patch re-factors the RuntimeDyldImpl to support multiple formats as
> following:
>
>
>
> All MachO-specific code has been moved to a new MachODyldImpl class which
> derives from RuntimeDyldImpl.
> Changed RuntimeDyldImpl class to keep only code common for all formats.
> Changed RuntimeDyld::loadObject() to figure out the given object format and
> instantiate a specific implementation (for now only MachO is supported, but
> I’ll add implementation for ELF in the coming patches).
>
>
>
> How does it look?

Since you haven't gotten a response, I'll say that the concept looks
fine.  Please generate the patch on top of a couple svn copy's from
RuntimeDyld.cpp to MachODyldImpl.cpp/RuntimeDyldImpl.h to preserve the
history from the original files.  Otherwise, looks fine to me.

It would be nice if Jim could comment on this, since he wrote most of
this code, although he might not be checking email over the July 4
weekend.

-Eli