[llvm-commits] [llvm] r134198 - /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Jim Grosbach grosbach at apple.com
Thu Jun 30 16:53:22 PDT 2011


On Jun 30, 2011, at 4:51 PM, Eric Christopher wrote:

> 
> On Jun 30, 2011, at 3:24 PM, Jim Grosbach wrote:
> 
>> 
>> On Jun 30, 2011, at 3:17 PM, Eric Christopher wrote:
>> 
>>> Author: echristo
>>> Date: Thu Jun 30 17:17:01 2011
>>> New Revision: 134198
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=134198&view=rev
>>> Log:
>>> Add a convenience typedef for std::pair<unsigned, const TargetRegisterClass*>.
>>> 
>>> No functional change.
>>> 
>>> Part of rdar://9119939
>>> 
>>> Modified:
>>>  llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>>> 
>>> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=134198&r1=134197&r2=134198&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
>>> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Thu Jun 30 17:17:01 2011
>>> @@ -7527,7 +7527,8 @@
>>> return weight;
>>> }
>>> 
>>> -std::pair<unsigned, const TargetRegisterClass*>
>>> +typedef std::pair<unsigned, const TargetRegisterClass*> Pair;
>>> +Pair
>> 
>> <nit>Mind giving the typedef a more informational name?</nit>
> 
> Lacking a better name you get this:
> 
> [yendi:Data/sources/llvm] echristo% svn ci
> Sending        lib/Target/ARM/ARMISelLowering.cpp
> Transmitting file data .
> Committed revision 134210.
> 
> :)
Works for me. Now when I need to handle two remote control cars at once, I know where to look!

-j



More information about the llvm-commits mailing list