[llvm-commits] [patch] Fix deprecation warning in lit on OS X

[Jordy Rose]

Ah, thanks. It turns out it's even simpler to just reuse the 'capture' function defined below in Util.py.

Is commit access for the Clang repo the same as the LLVM trunk?

Jordy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Util.py.patch
Type: application/octet-stream
Size: 559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110629/4d0ce5b5/attachment.obj>
-------------- next part --------------



On Jun 29, 2011, at 16:46, Andrew Trick wrote:

> On Jun 29, 2011, at 11:57 AM, Jordy Rose wrote:
>> I usually hang out on the Clang side of things, but I've noticed that the lit tests have a deprecation warning about 'popen2' that comes up on OS X. The attached patch replaces the use of 'popen2' with 'subprocess.Popen'.
>> 
>> Jordy
> 
> Looks good.
> 
> FWIW, the more common idiom seems to be "out,_ = p.communicate()"
> 
> -Andy