[llvm-commits] [llvm] r133900 - /llvm/trunk/lib/CodeGen/RegisterCoalescer.h

[Jakob Stoklund Olesen]

On Jun 26, 2011, at 3:44 PM, Rafael Espindola wrote:

> Author: rafael
> Date: Sun Jun 26 17:44:34 2011
> New Revision: 133900
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=133900&view=rev
> Log:
> Remove unused methods.

Actually, you can remove the entire RegallocQuery interface, it is unused.

The RegisterCoalescer class can be made private to RegisterCoalescer.cpp. Only the CoalescerPair class is used elsewhere.

/jakob

> 
> Modified:
>    llvm/trunk/lib/CodeGen/RegisterCoalescer.h
> 
> Modified: llvm/trunk/lib/CodeGen/RegisterCoalescer.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegisterCoalescer.h?rev=133900&r1=133899&r2=133900&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/RegisterCoalescer.h (original)
> +++ llvm/trunk/lib/CodeGen/RegisterCoalescer.h Sun Jun 26 17:44:34 2011
> @@ -142,18 +142,6 @@
>       initializeRegisterCoalescerPass(*PassRegistry::getPassRegistry());
>     }
> 
> -    /// Run the coalescer on this function, providing interference
> -    /// data to query.  Return whether we removed any copies.
> -    virtual bool coalesceFunction(MachineFunction &mf,
> -                                  RegallocQuery &ifd) {
> -      // This runs as an independent pass, so don't do anything.
> -      return false;
> -    }
> -
> -    /// Reset state.  Can be used to allow a coalescer run by
> -    /// PassManager to be run again by the register allocator.
> -    virtual void reset(MachineFunction &mf) {}
> -
>     /// Register allocators must call this from their own
>     /// getAnalysisUsage to cover the case where the coalescer is not
>     /// a Pass in the proper sense and isn't managed by PassManager.
> @@ -220,7 +208,6 @@
>   ///   // We don't reset the coalescer so if it's already been run this
>   ///   // takes almost no time.
>   ///   LinearScanRegallocQuery ifd(*li_);
> -  ///   coalescer.coalesceFunction(fn, ifd);
>   ///
>   class RegallocQuery {
>   public:
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits