[llvm-commits] [llvm] r133516 - /llvm/trunk/tools/lto/LTOModule.cpp

[Chad Rosier]

Hi Jay,
This was causing link-time failures in the llvm test-suite when run with -flto, so I reverted in r133995.  I didn't see any obvious reason for this to be causing a problem, so I filed PR10210 in bugzilla to try and track the problem.  If you have a second to check this out it would be greatly appreciated.

 Regards,
  Chad

On Jun 21, 2011, at 8:36 AM, Jay Foad wrote:

> Author: foad
> Date: Tue Jun 21 10:36:24 2011
> New Revision: 133516
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=133516&view=rev
> Log:
> Remove some unnecessary uses of c_str().
> 
> Modified:
>    llvm/trunk/tools/lto/LTOModule.cpp
> 
> Modified: llvm/trunk/tools/lto/LTOModule.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/LTOModule.cpp?rev=133516&r1=133515&r2=133516&view=diff
> ==============================================================================
> --- llvm/trunk/tools/lto/LTOModule.cpp (original)
> +++ llvm/trunk/tools/lto/LTOModule.cpp Tue Jun 21 10:36:24 2011
> @@ -208,7 +208,7 @@
>     if (objcClassNameFromExpression(c->getOperand(1), superclassName)) {
>       NameAndAttributes info;
>       StringMap<NameAndAttributes>::value_type &entry =
> -        _undefines.GetOrCreateValue(superclassName.c_str());
> +        _undefines.GetOrCreateValue(superclassName);
>       if (!entry.getValue().name) {
>         const char *symbolName = entry.getKey().data();
>         info.name = symbolName;
> @@ -220,7 +220,7 @@
>     std::string className;
>     if (objcClassNameFromExpression(c->getOperand(2), className)) {
>       StringSet::value_type &entry =
> -        _defines.GetOrCreateValue(className.c_str());
> +        _defines.GetOrCreateValue(className);
>       entry.setValue(1);
>       NameAndAttributes info;
>       info.name = entry.getKey().data();
> @@ -243,7 +243,7 @@
>       NameAndAttributes info;
> 
>       StringMap<NameAndAttributes>::value_type &entry =
> -        _undefines.GetOrCreateValue(targetclassName.c_str());
> +        _undefines.GetOrCreateValue(targetclassName);
> 
>       if (entry.getValue().name)
>         return;
> @@ -264,7 +264,7 @@
>     NameAndAttributes info;
> 
>     StringMap<NameAndAttributes>::value_type &entry =
> -      _undefines.GetOrCreateValue(targetclassName.c_str());
> +      _undefines.GetOrCreateValue(targetclassName);
>     if (entry.getValue().name)
>       return;
> 
> @@ -375,7 +375,7 @@
> 
>   // add to table of symbols
>   NameAndAttributes info;
> -  StringSet::value_type &entry = _defines.GetOrCreateValue(Buffer.c_str());
> +  StringSet::value_type &entry = _defines.GetOrCreateValue(Buffer);
>   entry.setValue(1);
> 
>   StringRef Name = entry.getKey();
> @@ -436,7 +436,7 @@
>   mangler.getNameWithPrefix(name, decl, false);
> 
>   StringMap<NameAndAttributes>::value_type &entry =
> -    _undefines.GetOrCreateValue(name.c_str());
> +    _undefines.GetOrCreateValue(name);
> 
>   // we already have the symbol
>   if (entry.getValue().name)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits