[llvm-commits] [llvm] r133858 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Chad Rosier]

You are correct!  Thanks Frits.  Committed revision 133874.

 Chad


On Jun 25, 2011, at 2:23 AM, Frits van Bommel wrote:

> On 25 June 2011 04:04, Chad Rosier <mcrosier at apple.com> wrote:
>> +  } else if (Arg.getOpcode() == ISD::FrameIndex && Flags.isByVal()) {
>> +    FrameIndexSDNode *FINode = dyn_cast<FrameIndexSDNode>(Arg);
>> +    FI = FINode->getIndex();
> 
> That dyn_cast<> should probably be a cast<>, because
> 1) if it fails it's an error anyway, and
> 2) you're already checking that it can't fail beforehand.